Add target CREATEDB preflight check for snapshot DB creation#996
Open
lghuy05 wants to merge 14 commits into
Open
Add target CREATEDB preflight check for snapshot DB creation#996lghuy05 wants to merge 14 commits into
lghuy05 wants to merge 14 commits into
Conversation
lghuy05
changed the title
Contributor
Author
|
I will resolve the conflict in a few days |
Collaborator
|
How do you handle if the database pgstream is supposed to create is missing? It seems to me that you are using the connection string that contains the database to be created. |
Contributor
Author
|
Merged lastest |
lghuy05
force-pushed
the
feat/target-createdb-privileges
branch
from
July 16, 2026 15:59
4b2f9a3 to
5745369
Compare
kvch
reviewed
Jul 21, 2026
kvch
reviewed
Jul 21, 2026
kvch
reviewed
Jul 21, 2026
9 tasks
kvch
added a commit
that referenced
this pull request
Jul 21, 2026
) #### Description In #996 (fork `lghuy05/pgstream`): the workflow_run fired and downloaded the artifact, then logged `expected exactly one open PR for <sha>, found 0; skipping coverage comment`. From now on we resolve the PR by head repo + branch instead of by commit association: - Call `pulls.list` with `head: "${wr.head_repository.owner.login}:${wr.head_branch}"`, which works for both fork and same-repo PRs. - Keep the `pr.head.sha === head_sha` guard so a superseded push doesn't get commented, and the "exactly one match or skip" behavior. - Drop the now-redundant branch/repo mismatch checks (the `head` filter already scopes the query). #### Type of Change Please select the relevant option(s): - [ ] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) - [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 📚 Documentation update - [ ] 🔧 Refactoring (no functional changes) - [ ] ⚡ Performance improvement - [ ] 🧪 Test coverage improvement - [x] 🔨 Build/CI changes - [ ] 🧹 Code cleanup
CoverageTotal: 57.9% (+0.1% vs Coverage in packages changed by this PR:
|
…arget-createdb-privileges # Conflicts: # internal/postgres/pg_restore_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new access preflight check for
pgstream checkto verify that the target Postgres role has theCREATEDBprivilege when snapshot schema restore is configured withcreated_target_db: true.Related Issue(s)
pgstream checkcommand for pre-migration sanity checks #897Type of Change
Please select the relevant option(s):
Changes Made
TargetCreateDBPrivilegeCheckto the access preflight checkscreate_target_db: trueTesting
Checklist
Additional Notes
This change only applies to the snapshot schema restore path for Postgres targets. The new check validates the current target session role by querying
pg_rolesforrolcreatedb, and returns an actionable finding when the privilege is missing.